Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow building of the ufs-weather-model, WW3 pre/post execs for GFS, GEFS, SFS in the same clone of global-workflow #3098

Open
wants to merge 37 commits into
base: develop
Choose a base branch
from
Open

Allow building of the ufs-weather-model, WW3 pre/post execs for GFS, GEFS, SFS in the same clone of global-workflow #3098

wants to merge 37 commits into from
+359 −374

Conversation

aerorahul
Copy link
Contributor

@aerorahul aerorahul commented Nov 14, 2024 •
edited
Loading

Description

GFS and GEFS (and now SFS) uses different compile time options for the UFS-weather-model. For the purposes of CI testing, a multi-build pipeline under Jenkins was created by @TerrenceMcGuinness-NOAA. This served well, until now. With the inclusion of SFS, a third variety of the model is being built. Under the multi-build pipeline paradigm, a second (or third) clone and build of the global-workflow is required. This adds cloning and compilation time of the global-workflow.

This PR allows compiling the ufs-weather-model in a single clone of the global-workflow. The compiled executables based on the options for GFS, GEFS, and SFS results in a model executable as gfs_model.x, gefs_model.x, and sfs_model.x. The forecast script uses the right executable.

This PR also differentiates the WW3 pre/post executables based on gfs_ or gefs_. SFS variants need to be introduced, when NET=sfs is added.
In the process of updating the WW3 pre/post executable names, it was discovered (via grep) the following are not used:

  • ww3_prep
  • ww3_outf
  • ww3_ounf
  • ww3_ounp
    These need to be confirmed by running the workflow to ensure they are indeed not used at runtime.

This PR also updates the Jenkinsfile to use the multi-build from the single location.

Type of change

  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

This PR does not update any submodules.

How has this been tested?

In progress

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 4, 2024
View reviewed changes
sorc/build_ww3prepost.sh Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 5, 2024
View reviewed changes
scripts/exgfs_wave_post_pnt.sh Fixed Show fixed Hide fixed
ush/wave_grib2_sbs.sh Fixed Show fixed Hide fixed
ush/wave_grib2_sbs.sh Fixed Show fixed Hide fixed
ush/wave_grib2_sbs.sh Fixed Show fixed Hide fixed
ush/wave_grid_interp_sbs.sh Fixed Show fixed Hide fixed
ush/wave_grid_moddef.sh Fixed Show fixed Hide fixed
ush/wave_prnc_cur.sh Fixed Show fixed Hide fixed
@aerorahul aerorahul changed the title Allow building of the ufs-weather-model for GFS, GEFS, SFS in the same clone of global-workflow Allow building of the ufs-weather-model, WW3 pre/post execs for GFS, GEFS, SFS in the same clone of global-workflow Dec 5, 2024
@aerorahul
Copy link
Contributor Author

I am going to mark this as ready for review to gather feedback on the code changes before I commence extensive testing.

@aerorahul aerorahul marked this pull request as ready for review December 6, 2024 19:07
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 6, 2024
View reviewed changes
sorc/build_ww3prepost.sh Fixed Show fixed Hide fixed
JessicaMeixner-NOAA
JessicaMeixner-NOAA reviewed Dec 6, 2024
View reviewed changes
sorc/build_ww3prepost.sh Show resolved Hide resolved
ush/wave_grid_interp_sbs.sh Outdated Show resolved Hide resolved
sorc/build_ww3prepost.sh Show resolved Hide resolved
@TerrenceMcGuinness-NOAA
Copy link
Collaborator

This fail is from PR 307 in my forked repo for testing this build using the updated CI pipline:

running the C48mx500_hybAOWCDA FAILED on Hercules in Build# 6 with error logs:

/work2/noaa/global/CI/HERCULES/307/RUNTESTS/COMROOT/C48mx500_hybAOWCDA_22a4e28b/logs/2021032500/gdas_marineanlletkf.log

Follow link here to view the contents of the above file(s): (link)

All the other CI tests are all languishing in the Priority queues on Hercules

@aerorahul
undo the fix and reintroduce the incorrect logic. Fixing the bug open…
5079448 
…s another bug that needs evaluation on the purpose of the logic. A FIXME tag has been added
@JessicaMeixner-NOAA JessicaMeixner-NOAA mentioned this pull request Dec 12, 2024
Open
@aerorahul
Copy link
Contributor Author

@guillaumevernieres

This fail is from PR 307 in my forked repo for testing this build using the updated CI pipline:

running the C48mx500_hybAOWCDA FAILED on Hercules in Build# 6 with error logs:

/work2/noaa/global/CI/HERCULES/307/RUNTESTS/COMROOT/C48mx500_hybAOWCDA_22a4e28b/logs/2021032500/gdas_marineanlletkf.log

Follow link here to view the contents of the above file(s): (link)

All the other CI tests are all languishing in the Priority queues on Hercules

@TerrenceMcGuinness-NOAA
I am not sure why this is the case. It seems like files are missing. I will wait for 3149 to finish running on Hercules to confirm it ran this test successfully in that PR.

TerrenceMcGuinness-NOAA
TerrenceMcGuinness-NOAA previously approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates to the Jenkinsfile pipeline script look good. The try/catch on the scm checkout looks strong too. An initial test of the pipeline worked fine in a forked branch in the development project. When CM (@WalterKolczynski-NOAA) is ready we should launch a CI test directly in this PR using multiple labels.

@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera and removed CI-Wcoss2-Failed **Bot use only** CI testing on WCOSS for this PR has failed CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress labels Dec 12, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera labels Dec 12, 2024
@WalterKolczynski-NOAA
Copy link
Contributor

Will run CI on Hercules as well once the PRs already running there have completed.

@emcbot emcbot added CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Dec 12, 2024
@emcbot
Copy link

emcbot commented Dec 12, 2024

CI Passed on Hera in Build# 1
Built and ran in directory /scratch1/NCEPDEV/global/CI/3098


Experiment C48_ATM_50794488 Completed 2 Cycles: *SUCCESS* at Thu Dec 12 19:37:04 UTC 2024
Experiment C48mx500_3DVarAOWCDA_50794488 Completed 2 Cycles: *SUCCESS* at Thu Dec 12 19:37:04 UTC 2024
Experiment C48mx500_hybAOWCDA_50794488 Completed 2 Cycles: *SUCCESS* at Thu Dec 12 19:43:22 UTC 2024
Experiment C96_S2SWA_gefs_replay_ics_50794488 Completed 1 Cycles: *SUCCESS* at Thu Dec 12 19:50:06 UTC 2024
Experiment C96C48_hybatmaerosnowDA_50794488 Completed 3 Cycles: *SUCCESS* at Thu Dec 12 20:56:27 UTC 2024
Experiment C96_atm3DVar_50794488 Completed 3 Cycles: *SUCCESS* at Thu Dec 12 21:02:22 UTC 2024
Experiment C96C48_hybatmDA_50794488 Completed 3 Cycles: *SUCCESS* at Thu Dec 12 21:02:33 UTC 2024
Experiment C96C48_ufs_hybatmDA_50794488 Completed 3 Cycles: *SUCCESS* at Thu Dec 12 21:32:57 UTC 2024
Experiment C48_S2SW_50794488 Completed 2 Cycles: *SUCCESS* at Thu Dec 12 21:51:52 UTC 2024
Experiment C48_S2SWA_gefs_50794488 Completed 1 Cycles: *SUCCESS* at Thu Dec 12 22:22:51 UTC 2024

@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules label Dec 13, 2024
@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules labels Dec 13, 2024
@emcbot emcbot added CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully and removed CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels Dec 13, 2024
@emcbot
Copy link

emcbot commented Dec 13, 2024

CI Passed on Hercules in Build# 2
Built and ran in directory /work2/noaa/global/CI/HERCULES/3098


Experiment C48mx500_3DVarAOWCDA_ee90bec1 Completed 2 Cycles: *SUCCESS* at Fri Dec 13 13:03:55 CST 2024
Experiment C48mx500_hybAOWCDA_ee90bec1 Completed 2 Cycles: *SUCCESS* at Fri Dec 13 13:03:58 CST 2024
Experiment C48_ATM_ee90bec1 Completed 2 Cycles: *SUCCESS* at Fri Dec 13 13:10:02 CST 2024
Experiment C96_S2SWA_gefs_replay_ics_ee90bec1 Completed 1 Cycles: *SUCCESS* at Fri Dec 13 13:59:05 CST 2024
Experiment C96_atm3DVar_ee90bec1 Completed 3 Cycles: *SUCCESS* at Fri Dec 13 14:04:39 CST 2024
Experiment C96C48_hybatmDA_ee90bec1 Completed 3 Cycles: *SUCCESS* at Fri Dec 13 14:35:00 CST 2024
Experiment C48_S2SW_ee90bec1 Completed 2 Cycles: *SUCCESS* at Fri Dec 13 15:35:59 CST 2024
Experiment C48_S2SWA_gefs_ee90bec1 Completed 1 Cycles: *SUCCESS* at Fri Dec 13 17:14:42 CST 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA left review comments

@JessicaMeixner-NOAA JessicaMeixner-NOAA JessicaMeixner-NOAA left review comments

@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA left review comments

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA left review comments

@sbanihash sbanihash Awaiting requested review from sbanihash sbanihash is a code owner

@KateFriedman-NOAA KateFriedman-NOAA Awaiting requested review from KateFriedman-NOAA KateFriedman-NOAA is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aerorahul @WalterKolczynski-NOAA @JessicaMeixner-NOAA @TerrenceMcGuinness-NOAA @emcbot @DavidHuber-NOAA